Repository navigation
test(app): isolate component coverage with storybook - #45142
Merged
Merged
Conversation
opencode-agent
Bot
force-pushed
the
app-component-tests
branch
from
August 26, 2026 18:28
cbbfd34 to
ed48277
Compare
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
Co-authored-by: Brendonovich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/storybook/playwright/. Component suites remain separately filterable from default unit/browser tests and required full-app E2E CI.Assertion Restoration
A case-by-case audit found that some earlier moves preserved visible outcomes but lost fixture or integration guarantees. This revision restores all 19 weakened cases without new Storybook entries:
The independent re-audit covers all 132 expanded merged-v2 baseline contracts, cross-checked against the initial 124-case baseline. Final coverage is 113 full-app E2E contracts + 19 intentionally isolated rendering contracts. The full component suite remains 45 tests, including supplemental coverage. The earlier 19 assertion gaps were restored; the separately approved animation-sampling policy change below intentionally removes two animation-only assertions. Rendering and integration checks still have different execution boundaries.
Focused Animation Policy
At Brendan's request, remove only the flaky
expectTerminalTopMotionrequirement interminal-hidden.spec.ts: more than six sampled positions and a maximum per-sample movement below 30% of the range. Remove its unused sample/reset helper code. 0 test cases removed; 1 mixed test retained; 2 animation-only assertion sites removed. All other 53 assertion sites in that file, including final geometry, alignment, visibility, caching and placement behavior, are unchanged. Other animation-event and performance-profiling checks were not swept. This is an intentional coverage-policy change, not a claim of identical animation coverage.The focused terminal test passed 10 repetitions with 5 workers, including the parallel workload that previously reproduced the sampling failure.
Validation
packages/session-ui:systemd-run --user --scope --quiet -p TasksMax=768 bun run test:components -- --workers=2— 44 passed.packages/app: same component command — 1 passed.packages/app:PATH=/tmp/opencode/node-bun:$PATH systemd-run --user --scope --quiet -p TasksMax=768 --setenv=PATH=/tmp/opencode/node-bun:$PATH bun run test:e2e -- --workers=5— 113 passed.git diff --check— passed.Requested by: @Brendonovich (Brendan via Slack)