Repository navigation
fix(ai): replay native hosted tool items - #45038
Closed
rekram1-node wants to merge 1 commit into
Closed
rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
store: falseBefore and after
A completed hosted search produces the provider-native item:
{ "type": "web_search_call", "id": "ws_1", "status": "completed" }Before: A subsequent stateless request rewrote that item as a synthetic user message:
{ "role": "user", "content": [{ "type": "input_text", "text": "{\"type\":\"web_search_call\",\"id\":\"ws_1\",\"status\":\"completed\"}" }] }After: Continuing with the same provider preserves the original item, matching Codex history replay:
{ "type": "web_search_call", "id": "ws_1", "status": "completed" }If the next model belongs to another provider, the original item is not replayed as foreign provider state; its portable text representation remains available instead. Hosted generated images likewise continue to replay as input images.
Verification
bun test test/partial-json.test.ts test/tool-stream.test.ts test/provider/openai-responses.test.ts test/provider/openai-compatible-responses.test.ts test/provider/openai-responses-images.recorded.test.ts test/provider/openai-responses-websocket.recorded.test.ts test/provider/openai-chat.test.ts test/provider/anthropic-messages.test.ts test/provider/bedrock-converse.test.ts test/provider/xai-responses.test.ts test/response.test.ts test/tool-runtime.test.ts --timeout 30000 --only-failures(367 passing)RECORDED_PREFIX=openai-responses bun test test/provider/golden.recorded.test.ts --timeout 30000 --only-failuresbun typecheckfrompackages/aibunx prettier --check packages/ai/src/protocols/open-responses.ts packages/ai/test/provider/openai-responses.test.ts packages/ai/test/provider/xai-responses.test.ts