Repository navigation
fix(opencode): Terminal event exit completion handling. - #44966
Closed
RadomirMinkov wants to merge 5 commits into
Closed
RadomirMinkov wants to merge 5 commits into
RadomirMinkov wants to merge 5 commits into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
3 of 6 tasks
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44901
Type of change
What does this PR do?
This PR makes opencode run exit normally after the primary session emits a terminal step_finish event with reason: "stop", instead of waitiing indefinitely for a later idle event. It preserves the final JSON event and existing continuation behavior for non-terminal reasons such as unknown.
How did you verify your code works?
The code change was verified with OpenCode’s real subprocess test suite, which launches the CLI as an external process and covers successful JSON runs, continuation after reason: "unknown", attach mode, errors, and signal cleanup. All 13 tests passed, the successful-run test confirmed the final event was step_finish with reason: "stop", and the full package typecheck also passed.
The patched source was then run directly against the same backend used by the Harbor evaluations, without Harbor’s supervisor or forced process termination. It emitted the expected response and terminal step_finish event, then exited naturally with status 0; however, we should not claim that the patched local binary itself was run through Harbor-the earlier Harbor runs tested the wrapper workaround, not this exact upstream patch.
The result from the tests was that a successful model response was received where before that was not the case. The emited termian lstep_finish event with reason: "stop" exited naturally with status 0. These changes make a terminal finish to stop the primary opencode run event loops.
Screenshots / recordings
This is not a UI change, so no screenshot or recordings are needed.
Checklist