Skip to content

fix(ai): classify missing chat finish reasons as incomplete - #44864

Merged
rekram1-node merged 1 commit into
v2from
incomplete-stream
Aug 25, 2026
Merged

rekram1-node merged 1 commit into
v2from
incomplete-stream

Conversation

@rekram1-node

Copy link
Copy Markdown
Collaborator

Summary

  • classify Chat Completions streams that end without a required finish reason as incomplete streams
  • allow the existing session runner interrupted-stream recovery path to recognize these failures
  • extend the existing Chat compatibility regression test to assert the classification

Test plan

  • bun test test/provider/openai-chat.test.ts test/provider/openai-compatible-chat.test.ts from packages/ai
  • bun typecheck from packages/ai

@rekram1-node
rekram1-node merged commit 895eff0 into v2 Aug 25, 2026
8 of 9 checks passed
@rekram1-node
rekram1-node deleted the incomplete-stream branch August 25, 2026 03:37
jinhuang712 pushed a commit to jinhuang712/opencode that referenced this pull request Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant