fix(core): serialize prompt settlement around event publication - #44340

AI code review — automated review for reference, author can ignore or act on any point.

Correct fix for a real race — the old order (publish first, settle/delete after) let a second reply slip through pending.get() while listeners delayed the first publish inside events.publish, producing double settlement and duplicate broadcasts. Claiming the entry first, restoring it only when the publish itself fails, is exactly right, and moving pending.delete() before the deferred resolution keeps list-pollers consistent with the broadcast. The Array.from(pending) snapshots in both cascade loops (packages/core/src/permission.ts:~245, ~267) are necessary now that the loop mutates mid-iteration across suspension points. The gated-listener tests are the highlight: they deterministically reproduce the interleaving and assert exactly-one event, NotFoundError for the loser, and an empty final list (packages/core/test/permission.test.ts:286-319, mirrored for questions including reject in question.test.ts:92-128).

Two small suggestions:

1. The claim→publish→restore-on-error sequence is now copy-pasted four times (permission.ts primary/reject-cascade/always-cascade, question.ts reply/reject). Extracting a settleClaimed(id, item, event) helper would keep the invariant in one place — this is precisely the kind of subtle ordering that drifts in future edits.

2. Cascade failure path is untested. Both tests gate only the primary publish. A companion test making the second (cascaded) publish fail would pin the recovery semantics: earlier items stay settled, the failing item is restored to pending, and the error propagates without corrupting the map.

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.