Repository navigation
fix(ai): preserve unique Gemini function call IDs - #44051
Merged
Merged
Conversation
- use part.functionCall.id when provided by Gemini models - generate unique identifier fallbacks when tool call IDs are omitted - remove per-request counter state that caused duplicate tool_0 IDs Signed-off-by: Major Hayden <[email protected]>
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
Signed-off-by: Major Hayden <[email protected]> Co-authored-by: Major Hayden <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43940
Extracts the Gemini-specific fix from #43961 without the separate Core shell/Job ID change.
part.functionCall.idwhen Gemini provides one.tool_0,tool_1, ... counter.Original implementation and commit authored by @major in #43961. The provider-agnostic shell Job ID decoupling can be reviewed separately.
Verification:
cd packages/ai && bun test test/provider/gemini.test.ts --timeout 30000 --only-failurescd packages/ai && bun typecheck