Repository navigation
feat(i18n): add notebook memory keys across locales - #43066
SaeedAqamiri wants to merge 2 commits into
Conversation
github-actions
Bot
added
needs:compliance
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
SaeedAqamiri
changed the title
|
|
Add the command.session.record-notes and ui.message.saveLearnings keys to all app and ui locale files (English fallback values, real translations in fa/zh), so the save-learnings button and /save command never render a raw key in any locale.
Only fa/zh carry real translations; the other locales kept English values
that are redundant with the en-dict fallback ({ ...en, ...locale }). Remove
them so new keys never render as stale English in non-en locales and future
translation work is unambiguous.
09e3f3e to
09cdae8
Compare
Locale translations move to a separate PR (anomalyco#43066) to shrink the memory PR diff; English keys remain because the app/ui i18n types derive from en and the runtime merges { ...en, ...locale } with English as the fallback.
09cdae8 to
ff9d423
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
|
Still active. Addressed the review: the redundant English-placeholder keys were removed from the ~118 non-translated locales so the en-dict fallback applies, keeping only en/fa/zh (source + real translations). Part of the notebook memory proposal in #43068. Could a maintainer please reopen it for human review? |
Issue for this PR
Closes #43068 (notebook memory feature) — carries the locale keys for the memory feature separately so the core PR (#43058) stays reviewable.
Type of change
What does this PR do?
Adds
command.session.record-notes(.description)(app) andui.message.saveLearnings(ui) keys to all locale files. English is the source;fa/zhcarry real translations; the remaining locales use English values, and the runtime already falls back to English via the{ ...en, ...locale }merge.How did you verify your code works?
bun typecheckgreen (app + ui).Screenshots / recordings
N/A.
Checklist