Skip to content

fix(core): preserve explicit provider auth bypass - #42509

Closed
mhart wants to merge 1 commit into
anomalyco:v2from
mhart:mhart/explicit-provider-auth-bypass
Closed

mhart wants to merge 1 commit into
anomalyco:v2from
mhart:mhart/explicit-provider-auth-bypass

Conversation

@mhart

@mhart mhart commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added contributor needs:compliance This means the issue will auto-close after 2 hours. needs:title labels Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Hey! Your PR title Preserve explicit provider auth bypass doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@mhart
mhart changed the base branch from dev to v2 August 14, 2026 04:19
@mhart mhart changed the title Preserve explicit provider auth bypass fix(core): preserve explicit provider auth bypass Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Aug 14, 2026
@github-actions github-actions Bot closed this Aug 14, 2026
@thdxr thdxr reopened this Aug 15, 2026
@thdxr

thdxr commented Aug 15, 2026

Copy link
Copy Markdown
Member

Thanks for identifying the native provider auth regression. While reviewing this, we found that settings.apiKey: "" was also being used as a catalog enablement signal, which coupled provider activation to authentication settings.

We carried your original commit and attribution into #42791, which replaces the empty-key sentinel with explicit provider activation and applies Auth.none for enabled API-key routes without credentials. Closing this PR in favor of that replacement.

@thdxr thdxr closed this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants