fix(tui): persist plugin activation toggles - #42410

AI code review — automated review for reference; please use your judgment.

• packages/tui/src/feature-plugins/system/plugins.tsx:67-72 — The toggle computes the desired state from the runtime snapshot (!current.active) instead of from the config draft it is about to mutate — If config and runtime ever diverge (external edit to opencode.json, an in-flight reconcile, or a previous toggle whose apply failed), clicking toggle can re-enable a plugin the user explicitly disabled (or vice versa) — the exact class of bug this PR sets out to fix. Suggestion: derive the effective state inside the update callback, e.g. check whether draft.plugins currently contains id or `-${id}` (absence = enabled) and flip that, so the decision is made against the same data being written.
• packages/tui/src/feature-plugins/system/plugins.tsx:74-79 — The soft-failure signal is gone: the old code showed a "Failed to update plugin …" toast when activate/deactivate returned false, but the new path treats any resolved config.update as success — a validation rejection or silent no-op write leaves the user with no feedback while the option footer keeps showing the stale active/inactive state. Suggestion: verify the resulting config (return value or a follow-up config.get()) contains the expected directive, and fall back to the error toast when it did not land.
• packages/tui/src/feature-plugins/system/plugins.tsx:70-80 — Persistence succeeding is not the same as the plugin actually toggling, yet finally(() => setLocked(false)) unlocks immediately after the config write — if the runtime reconcile fails afterwards (broken module, missed watcher event), the dialog is interactive again while showing a state that was never applied. Suggestion: await the expected flip in props.plugins.registered()/list() (with a timeout) before releasing the lock, or surface a "change applies on next reload" hint so the UI never claims success prematurely.
• packages/tui/src/config/plugin.ts:18-20 — When draft.plugins exists but is not an array, it is silently replaced with [directive], discarding whatever malformed value was stored — this hides authoring errors in the user's config instead of surfacing them. Suggestion: only default when the field is undefined/null; otherwise throw so the existing .catch in the caller turns it into a visible toast.
• packages/tui/test/plugin-toggle.test.ts:6-13 — Good unit coverage of setEnabled, and the hot-reload regression test is well done, but nothing drives the actual dialog toggle() through config.update to assert the written directive matches !active — the two issues above live precisely in that untested seam, so a regression there would ship unnoticed. Suggestion: extend the renderer harness (bootApp already accepts a config object) to trigger the plugins.toggle action and assert the resulting config contents.
• packages/tui/src/feature-plugins/system/plugins.tsx:75-78 — The error toast now shows the raw error.message with no indication of which plugin the failure belongs to (the old message named the plugin) — for multi-error failures this makes the toast hard to act on. Suggestion: restore the context, e.g. `Failed to update plugin ${current.id}: ${message}`.

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.