Repository navigation
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
is this issue dead? has it already been implemented in #39907? |
Author
Have not been tracking closely - will close. Thank you for the bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42246
Type of change
What does this PR do?
V2 generated a stable session cache key but only passed it through the OpenAI provider namespace. This meant OpenRouter did not receive the key its route already supports, while native OpenAI Chat did not lower the key into
prompt_cache_key.This passes the session key to OpenRouter, lowers it for native OpenAI Chat, and leaves generic OpenAI-compatible providers unchanged because they may reject unsupported fields. It restores the cache-affinity behavior described by #39907.
How did you verify your code works?
bun typecheckpassed inpackages/llmandpackages/coreScreenshots / recordings
Not applicable; this only changes provider request bodies.
Checklist