Repository navigation
fix(tui): retry migration status transport errors - #42188
Closed
kitlangton wants to merge 1 commit into
Closed
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing because we do not currently have a captured migration failure or regression test demonstrating this retry path. The change is plausible, but we should reproduce the transport failure and verify retry semantics before changing polling behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep the migration status overlay polling through temporary server transport loss.
Before / After
Before
A transient disconnect while the background service restarted ended migration polling and displayed a migration failure toast.
After
Transport errors retry after one second. Actual API or migration errors still surface, and unmount aborts polling without a stale toast.
How
ClientErrortransport failures inpackages/tui/src/component/migration-overlay.tsx.Scope
This PR does not change service version policy, replacement, stop behavior, discovery validation, service election, or TUI layout.
Testing
cd packages/tui && bun run test test/component(10 passed)cd packages/tui && bun typecheck