Repository navigation
fix(core): conservative shell permission fallback when tree-sitter assets cannot load - #42173
Closed
kitlangton wants to merge 1 commit into
Closed
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #42351, which removes the Core Tree-sitter runtime and conservatively treats unsupported or uncertain shell syntax as opaque. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep shell execution usable when tree-sitter parser assets cannot load, such as in workerd runtimes without filesystem-backed assets. Permission analysis falls back to one conservative command resource instead of failing the scan.
How
Capture parser loading with
Effect.exit. On failure, return the full command as the resource, derive the reusable save prefix from the existing token arity logic, and report no directories.Scope
Only changes the parser-load failure path in
packages/core/src/shell/parse.ts. Successful parser loading and detailed command/directory extraction are unchanged.Testing
bun run test test/shell-parse.test.ts test/permission.test.ts(16 passed)bun typecheckinpackages/coreNo direct failure-path test was added because the loader is a closed module-level singleton; injecting a load failure would require production refactoring beyond this focused fallback.