Repository navigation
Conversation
The question tool blocked indefinitely in ACP mode because the event handler was never wired up. question.asked events carry a QuestionV2 request ID that must be used for reply/reject — the tool call ID from message.part.updated is different and using it never unblocked the waiting Deferred. Fix: listen for question.asked and question.v2.asked events in the event subscription and forward them to a new ACPElicitation.Handler. The handler calls unstable_createElicitation when the client advertises elicitation support, and falls back to auto-reject otherwise. Fixes anomalyco#38121
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #38121
Type of change
What does this PR do?
The
questiontool blocked indefinitely in ACP mode. The root cause:question.askedevents carry a QuestionV2 request ID that must be passed tosdk.question.reply/rejectto unblock the waiting deferred — but the event subscription never handled these events at all, so the deferred never settled.The fix wires
question.askedandquestion.v2.askedinto the existing event handler switch and forwards them to a newACPElicitation.Handler. The handler callsunstable_createElicitationwhen the connected client advertises elicitation support (set duringinitialize), and falls back to auto-reject otherwise — preserving current behaviour for non-elicitation clients.How did you verify your code works?
Unit tests cover: accept, decline, cancel, unsupported client auto-reject, elicitation error, multi-question form, multi-select array schema, empty question list, unknown session,
message.part.updatednot triggering elicitation, missingtoolCallId, andquestion.v2.asked.Integration tests (subprocess) cover the accept path end-to-end with a real opencode process, auto-reject when the client omits elicitation capability, and the decline path.
Also verified against a live Docker Compose environment with nsjail:
create_elicitationarrives over the ACP wire with the correct schema, the form renders, and the accepted answer is injected back into the model turn.Checklist