Repository navigation
Conversation
When the LLM calls the built-in question tool, forward it to the ACP client as an unstable_createElicitation request so the client can render a structured form. Translate accept/decline/cancel back to sdk.question.reply/reject to unblock the waiting tool execution. Falls back to auto-reject when the client does not advertise elicitation support, preserving the existing behaviour for non-elicitation clients. Fixes anomalyco#38121
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Author
|
Closing — work in progress, not ready for upstream review yet. Will reopen when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/opencode/src/acp/elicitation.ts— a handler (modelled onpermission.ts) that translates thequestiontool part into anunstable_createElicitationACP request and maps the client response back tosdk.question.reply/rejectACPEvent.Subscription.handleToolPart— whentoolName === "question"and the state isrunning, the elicitation handler fires instead of the normalrunningToolpathConnectiontype in bothevent.tsandservice.tsto includeunstable_createElicitationTest plan
sdk.question.replyis calledsdk.question.rejectis calledsdk.question.rejectis calledunstable_createElicitationunstable_createElicitationthrows — falls back to rejectmultiple: true) — uses array schema withanyOfitemsFixes #38121