Repository navigation
fix(core): discover local plugin packages - #41784
Merged
Merged
Conversation
kitlangton
marked this pull request as ready for review
August 11, 2026 17:14
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41530
What
Discover local plugin packages placed as immediate child directories under
.opencode/plugin/or.opencode/plugins/, matching the documented V2 local discovery behavior.Before / After
Before: OpenCode scanned only direct
.tsand.jschildren. A directory such as.opencode/plugins/reviewer/was silently skipped even whenpackage.jsonexposed"exports": "./entry.ts"or the directory containedindex.ts/index.js.After: OpenCode enumerates each discovery directory once and loads immediate child packages in deterministic code-unit order. It resolves the first existing contained entrypoint from string
exports,module,main,index.ts, thenindex.js, while preserving direct-file and symlink discovery.How
packages/core/src/config/plugin/source.tsusesFSUtil.readDirectoryEntriesto classify immediate files, directories, and symlinks without overlapping globs.packages/core/test/config/plugin.test.tscovers stringexports, fallback through missingexportstomodule, fallback through missingmoduletomain,index.js, lexical traversal rejection, and symlink escape rejection.Scope
exportsor extensionless Node resolution; the documented and reported case is a string path to an existing entrypoint.Testing
bun run test test/config/plugin.test.tsfrompackages/core(15 passed)bun typecheckfrompackages/corebunx prettier --check packages/core/src/config/plugin/source.ts packages/core/test/config/plugin.test.tsgit diff --checkbun turbo typecheck --concurrency=3(33 tasks passed)OPENCODE_CONFIG_DIR, queried/api/plugin, and observed bothrepro.direct-fileandrepro.directory-packageafter catalog initialization