Repository navigation
Conversation
Co-authored-by: TRAE CLI <[email protected]>
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41763
Type of change
What does this PR do?
Stops retrying TUI audio startup after the playback device is unavailable. The failed native engine is disposed, cached sounds are cleared, and audio remains disabled until the next TUI lifecycle.
This prevents each later attention sound from re-running native ALSA device discovery and writing another diagnostics block over the terminal.
The remaining first native diagnostics block is tracked upstream in anomalyco/opentui#1358.
How did you verify your code works?
bun test test/audio.test.tsinpackages/tuibun testinpackages/tui— 194 passed, 1 skippeddispose()allows a fresh lifecycle to try again.libasound2and no/dev/snd: three playback attempts produced 105 ALSA stderr lines and three startup errors before the fix, versus 35 lines and one startup error after it.Local
bun typecheckis currently blocked by existing Buffer/Node type incompatibilities in unchanged files and dependencies, including@ff-labs/fff-bun,packages/core, and the existingpackages/tui/src/audio.tsevent typing. GitHub CI will run the required typecheck in the repository environment.Screenshots / recordings
Not included. The Linux reproduction confirms that the change prevents repeated native ALSA stderr blocks. The first native startup attempt can still emit one diagnostics block.
Checklist