Repository navigation
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
4 of 6 tasks
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37692
Type of change
What does this PR do?
I ran into this while building opencode-voice, a local voice input plugin for OpenCode.
For hold-to-talk, the plugin needs to know when a key is released. OpenCode supports release keybindings, but users could not turn on Kitty keyboard release events in
tui.json.This PR adds an opt-in setting:
{ "kitty_keyboard": { "events": true } }It is off by default because some xterm.js terminals handle release events badly.
The setting is used by both OpenCode TUI renderer paths. This makes hold-to-talk and other release-based keybindings possible in terminals with solid Kitty keyboard support, without changing the default behavior for everyone else.
How did you verify your code works?
The full pre-push check could not finish because pkg.pr.new was down and @solidjs/start could not be downloaded.
Screenshots / recordings
N/A. This is a TUI config and keyboard input change.
Checklist