Repository navigation
feat(tui): type into custom form answers - #41079
Closed
kitlangton wants to merge 2 commits into
Closed
kitlangton wants to merge 2 commits into
kitlangton wants to merge 2 commits into
Conversation
3 of 6 tasks
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Typing while Type your own answer is highlighted now opens the custom-answer editor and preserves the complete typed input. This removes the extra Enter press before entering a custom form answer.
Closes #34476.
How
packages/tui/src/routes/session/form.tsxintercepts unmodified printable input while the custom row is active, then buffers characters until the textarea is focused.packages/tui/src/mini/footer.form.tsxapplies the same behavior to the direct-run form footer.Scope
This PR covers printable typing only. Pasting from any selected option into the custom answer is handled separately in #41080.
Testing
bun run test test/cli/tui/form.test.tsx test/mini/footer.view.test.tsxfrompackages/tui: 44 passed, 4 skippedbun typecheckfrompackages/tuibun turbo typecheck --concurrency=3: 32 tasks passedDemo
The recording uses an isolated OpenCode Drive TUI with a simulated question response. It highlights Type your own answer, then types a complete custom value without pressing Enter first.
recording-d0a54941-1462-4f45-8177-29dba8116086.mp4