Repository navigation
fix(opencode): clear stale permission prompts - #40100
Closed
miaojixuezhang wants to merge 1 commit into
Closed
miaojixuezhang wants to merge 1 commit into
miaojixuezhang wants to merge 1 commit into
Conversation
miaojixuezhang
marked this pull request as ready for review
August 1, 2026 20:57
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This was referenced Sep 22, 2026
iceteaSA
pushed a commit
to iceteaSA/opencode
that referenced
this pull request
Sep 23, 2026
Interrupted or disposed permission requests were removed from the pending map without publishing permission.replied, so Web/Desktop/TUI kept a stale prompt. Approving that prompt later failed with Permission request not found: <id>. Route both cleanup paths (ask Effect.ensuring + instance finalizer) through a guarded cleanup helper that deletes the entry, publishes Event.Replied with reply: reject, and rejects the pending Deferred. The delete guard prevents duplicate events after a normal reply. Regression tests: - ask - publishes rejected reply event when interrupted (times out without this fix) - instance dispose now also asserts the reply event Closes anomalyco#29422 Revives anomalyco#40100 (closed by automated PR cleanup, not by review) (cherry picked from anomalyco#50595)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29422
Type of change
What does this PR do?
Interrupted or disposed permission requests were removed from the server without publishing
permission.replied, so Web/Desktop could keep a prompt that could no longer be answered. This routes both cleanup paths through one guarded helper that removes the request, publishes arejectreply, and rejects the pending deferred. The delete guard prevents duplicate events after a normal reply.How did you verify your code works?
bun test test/permission/next.test.ts— 80 pass.bun typecheckfrompackages/opencode.Screenshots / recordings
Not applicable; the stale prompt is cleared through the existing reply event reducer.
Checklist