Repository navigation
fix(desktop): open Windows terminals at the project directory - #40067
Closed
tancheng33 wants to merge 1 commit into
Closed
tancheng33 wants to merge 1 commit into
tancheng33 wants to merge 1 commit into
Conversation
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39851
Type of change
What does this PR do?
On Windows, the
open-pathIPC handler runsexecFile(<app>, [path])for every app. That works for editors (code,cursor, etc. accept a directory argument), but PowerShell interprets its first positional argument as a command to execute, so "Open in PowerShell" fails withCommandNotFoundExceptionon the project path.The fix: when the resolved app is
powershell/pwshon win32, spawn it with no arguments,cwdset to the project directory, anddetached: true+stdio: "ignore"so it gets its own console window starting in the project folder. Aspawn/errorlistener keeps the promise contract of the handler (rejects on ENOENT etc.). All other apps and platforms keep the existingexecFilepath.detached: trueon Windows gives the child its own console, and PowerShell starts in the inheritedcwd, which is exactly the expected behavior from the issue ("a PowerShell window opens with the working directory set to the project folder").How did you verify your code works?
bun typecheckinpackages/desktoppasses; full-repo typecheck (30 turbo tasks) passes via the pre-push hook.spawnsemantics (detachedon Windows = own console,cwdinherited). Happy to adjust if a maintainer with a Windows box spots an issue; the reporter of Desktop: Open in PowerShell fails on Windows — 'open-path' passes project path as a command (CommandNotFoundException) #39851 offered a clear repro to test against.Screenshots / recordings
Not a UI change (main-process IPC only).
Checklist