Repository navigation
fix(opencode): reconnect MCP servers when a tool call fails - #40062
Closed
zhang17-24 wants to merge 1 commit into
Closed
zhang17-24 wants to merge 1 commit into
zhang17-24 wants to merge 1 commit into
Conversation
A restarted MCP server leaves the client's StreamableHTTP connection dead without always firing onclose, so the cached tool set stayed stale forever: Desktop (and any long-lived session) kept calling the old server until the process restarted (issue anomalyco#40015). - McpTool now carries a reconnect hook that re-establishes the server's session through the normal connect/createAndStore path (which refreshes the cached tool definitions) - session tool execution triggers that hook when a tool call fails, so the agent's retry uses a fresh client once the server is back - MCP connection close also kicks off a backoff reconnect loop so a dead connection recovers without waiting for the next tool call
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40015
Type of change
What does this PR do?
A restarted MCP server leaves the client's StreamableHTTP connection dead without reliably firing onclose, so the cached tool set stayed stale: long-lived sessions kept calling the old server until the process restarted. McpTool now carries a reconnect hook that re-establishes the server session through the normal connect path (which refreshes the cached tool definitions), and session tool execution triggers it when a tool call fails so the agent's retry uses a fresh client.
How did you verify your code works?
Screenshots / recordings
N/A (not a UI change)
Checklist