Repository navigation
Conversation
filetype() indexed LANGUAGE_EXTENSIONS with path.extname(), an exact case-sensitive lookup. Uppercase extensions (COMPONENT.TSX, main.PY) and extensionless names (Makefile) missed entirely, so those files rendered without syntax highlighting. It also left five map keys unreachable: makefile, .html.erb, .js.erb, .css.erb, .json.erb. Lowercase the basename and try each dot-suffix longest-first, falling back to the whole name. diff-viewer.tsx carried a byte-identical private copy with the same bug; it now imports the shared helper.
github-actions
Bot
added
the
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39601
Type of change
What does this PR do?
filetype()indexedLANGUAGE_EXTENSIONSwithpath.extname(), an exact case-sensitive lookup. Uppercase extensions (COMPONENT.TSX,main.PY) and extensionless names (Makefile) missed entirely, so those files rendered with no syntax highlighting. It also left five map keys unreachable, sincepath.extname()only ever returns the final.xxx:makefile,.html.erb,.js.erb,.css.erb,.json.erb.Now it lowercases the basename and tries each dot-suffix longest-first, falling back to the whole name. That reaches the compound and bare-name keys without adding entries to the map.
diff-viewer.tsxhad a byte-identical private copy of the helper with the same bug - it now imports the shared one, dropping 8 lines and an unusedpathimport.How did you verify your code works?
Extended
packages/tui/test/util/filetype.test.tsfrom 2 to 8 tests: casing, extensionless names, compound suffixes, longest-suffix precedence (data.json-> json butdata.json.erb-> erb), paths.Checked they catch the bugs - against the unfixed source the casing and extensionless tests fail; with the fix 8/8 pass. The two original assertions are unchanged and still pass.
packages/tui:bun typecheckclean,bun test test/util/52/52 pass, oxlint warning count identical before and after.Screenshots / recordings
Not a UI change.
Checklist