Repository navigation
Fixed shimmer animation on permission deny - #3952
Closed
opencode-agent[bot] wants to merge 2 commits into
Closed
opencode-agent[bot] wants to merge 2 commits into
opencode-agent[bot] wants to merge 2 commits into
Conversation
Co-authored-by: rekram1-node <[email protected]>
Collaborator
|
/oc so this does work, but shouldn't the model name still display at teh bottom just not in simmering mode? |
Contributor
Author
|
Now the model name will display whenever the message is completed, regardless of whether there were tool calls or not. The shimmering version will only show during active processing, and the static version will show once completed. |
Co-authored-by: rekram1-node <[email protected]>
Collaborator
|
/oc it looks like that was actually intentional, undo your last commit |
Contributor
Author
|
Last commit undone successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
I've successfully located and fixed the bug where the progress animation doesn't stop when denying a command. Here's what I found and fixed:
Bug Location:
/home/runner/work/opencode/opencode/packages/opencode/src/session/prompt.tsin theprocessfunction around lines 1182-1187Root Cause: When a permission was rejected:
blocked = trueflag was set correctlytime.completed) was only set at the very end of processing!props.message.time.completedto remain trueFix Applied: Added a check after the switch statement (lines 1294-1296) to break out of the processing loop immediately when
blocked = true:How it works now:
blocked = trueassistantMsg.time.completed = Date.now()The fix ensures that when a user denies a permission request, the progress animation stops immediately instead of continuing indefinitely.
Closes #3951
opencode session | github run