Repository navigation
fix(core): align command reload pipeline and repair plugin fixture - #39171
Merged
Merged
Conversation
This was referenced Jul 27, 2026
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two repairs in the config-reload area:
config.changesconsumers share one shape.PluginSupervisor config > reloads an auto-discovered plugin when its file changestest: the consolidation refactor (8db7487) moved@opencode-ai/plugin's entrypoint fromsrc/index.tstosrc/promise/index.ts, and this test generates its plugin in a tmpdir where the bare package specifier cannot resolve — the absolute file URL it builds pointed at the deleted path, so the plugin never loaded. One-line path fix; the reload mechanism itself was never broken.How
ConfigCommandPlugin: one merged trigger stream (Stream.merge(sourceChanges, configUpdates)→ one debounce → onerunForEach) replaces the two separate forks, eliminating duplicateload()scans on correlated bursts and the stale-scan overwrite window onloaded.documents.isCommandSourceusesFSUtil.contains(Windows-robust, same helper Config'sreconcileuses) driven by asourceDirectoriesconstant.command.test.tsdrops its inlinesettle/advance/draincopies in favor oftest/lib/clock.tsfrom feat(core): reload agents from config change feed #39167, and renames theConfig.Testbinding toconfigTestto stop shadowing thebun:testimport.plugin.test.ts:mutablePluginimports../../../plugin/src/promise/index.ts.Testing
test/config/plugin.test.ts: 11/11 (previously 10/11), stable across 3 consecutive runs — this removes the last inheritedtest/configfailure from base CI.bun typecheckclean.