fix(core): close promise plugin event subscriptions on scope teardown by tiffanychum · Pull Request #38825 · anomalyco/opencode

tiffanychum · 2026-07-25T09:13:23Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Promise-based plugins that detach a for await on ctx.event.subscribe() never called return(), so each location expiry/reboot leaked a process-global PubSub subscriber and fan-out grew until idle servers burned a core on allocation. The promise bridge now registers a plugin-scope finalizer that closes the async iterator, so generation teardown unsubscribes even when the plugin never returns the iterator.

How did you verify your code works?

bun test test/plugin/promise.test.ts (10/10) and bun typecheck in packages/core.

Screenshots / recordings

N/A — not a UI change.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

Keep draining standalone server stdout after reading its readiness message so later server output does not write into a closed pipe. Install the Node CLI broken-pipe handler before loading the main entrypoint. Ignore only EPIPE while preserving all unrelated stdout errors. This prevents Windows Node builds from failing when the TUI prints its exit epilogue after renderer teardown.

Co-authored-by: James Long <[email protected]>

Co-authored-by: Aiden Cline <[email protected]>

Co-authored-by: Dax Raad <[email protected]>

Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Aiden Cline <[email protected]>

…anomalyco#38734)

Fixes anomalyco#36677 Co-authored-by: Cursor <[email protected]>

github-actions · 2026-07-25T09:13:32Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions · 2026-07-25T09:35:20Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

tiffanychum · 2026-07-25T15:39:58Z

Closing without merging: this branch was rebuilt/re-checked against current dev, and the original leak path is no longer reachable.

What changed upstream

PR fix(core): close promise plugin event subscriptions on scope teardown #38825 patched ctx.event.subscribe() in the Promise-plugin bridge (packages/core/src/plugin/promise.ts), closing the async iterator on plugin-scope teardown.
That API was removed when the namespaced hook API landed (909a1a6d7, “feat(plugin): add namespaced hook API”). Current PluginContext (Promise and Effect) has no event field; PluginHost.make does not expose one. packages/plugin/src/v2/effect/event.ts is an orphaned type stub and is not wired into the host.
Cherry-picking the old fix onto current dev still conflicts for that reason.

What we checked on current dev

No Promise/Effect plugin path can call ctx.event.subscribe() / Stream.toAsyncIterable(host.event.subscribe()).
Built-in subscribers that still use EventV2 (models-dev, opencode provider) run via Effect.forkScoped, so they are tied to the plugin/location scope rather than an unmanaged async iterator.
Without a reachable repro of subscriber accumulation across location invalidate/expiry, inventing a replacement fix would be speculative.

Leaving #36677 open for maintainer re-triage in case the original allocation-loop report still has a different root cause.

rekram1-node and others added 30 commits July 17, 2026 00:15

fix: rm used config

27e1692

node v2 cli support (anomalyco#36309)

a1b274e

feat(session): expose transient generation API (anomalyco#37433)

3db4458

ci: fix node publish multi-arch install (anomalyco#37497)

2180fb8

feat(tui): add hovered theme state (anomalyco#37404)

b26d948

chore: upgrade Effect to beta.98 (anomalyco#37498)

44f7bb7

test(tui): await diff tree context readiness (anomalyco#37501)

6517514

Co-authored-by: James Long <[email protected]>

fix(cli): stabilize Windows ARM64 Node builds (anomalyco#37503)

f847040

refactor(tui): migrate leaf views to V2 themes (anomalyco#37510)

d67e035

fix(tui): raise neutral permission backgrounds (anomalyco#37513)

bd79e24

fix(core): clarify user-executed shell history (anomalyco#37515)

9b3a465

Co-authored-by: Aiden Cline <[email protected]>

feat(tui): expose session header slot (anomalyco#37520)

48adb95

feat(tui): expose session composer top slot (anomalyco#37518)

bce9c63

refactor(tui): migrate dialog views to V2 themes (anomalyco#37516)

677526d

fix(simulation): normalize named key presses (anomalyco#37523)

3fc06ac

cli: rename node package to opencode-node (anomalyco#37528)

5d5b33f

feat(core): add tool namespaces (anomalyco#37529)

4bc8faa

fix(cli): restore plugin list diagnostics (anomalyco#37540)

f2a4011

Co-authored-by: Aiden Cline <[email protected]>

refactor(tui): migrate workflow views to V2 themes (anomalyco#37526)

c7a7900

feat(codemode): project OpenAPI schema directions (anomalyco#37361)

87d5b27

feat(tui): track hue source identity (anomalyco#37550)

fafb04e

fix(core): honor OAuth attempt expiration (anomalyco#37557)

987242b

fix(cli): elect managed service by port bind (anomalyco#37572)

6ea8247

Co-authored-by: Dax Raad <[email protected]>

fix(cli): simplify service registration lease (anomalyco#37576)

60ce33c

Co-authored-by: Dax Raad <[email protected]>

fix(cli): reduce startup overhead

22c23cb

fix(core): defer cyclic layer dependencies

c4830c1

docs: allow trusted cli installation

f2579c4

fix(tui): exit composer picker with up arrow (anomalyco#37601)

08a7080

feat(core): add runtime MCP controls (anomalyco#37308)

cd3cca0

Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Aiden Cline <[email protected]>

kitlangton and others added 16 commits July 24, 2026 18:02

fix(ai): layer prompt cache breakpoints (anomalyco#38725)

993f046

refactor(core): settle declined tool calls durably with typed reasons (…

5ae2d6d

…anomalyco#38734)

fix(core): authorize external glob paths (anomalyco#38714)

423fad7

fix(ai): report OpenAI cache writes (anomalyco#38735)

b09a066

fix(codemode): report interrupted tool calls (anomalyco#38741)

ee5460a

fix(tui): flag likely cache busts accurately (anomalyco#38727)

3193f3a

fix(core): clarify Code Mode tool availability (anomalyco#38745)

d66d0cb

fix(ai): align Anthropic stream handling (anomalyco#38733)

49bec25

fix(core): stream Code Mode tool progress (anomalyco#38718)

b317471

refactor(core): move static Code Mode guidance (anomalyco#38746)

d1d9701

fix(core): scope MCP execute guidance to Code Mode (anomalyco#38753)

13b6845

fix(ai): preserve Anthropic usage metadata (anomalyco#38751)

c7d7f61

fix(core): clarify code mode tool boundary (anomalyco#38785)

1291dc1

fix(tui): preserve workspace while reconnecting (anomalyco#38788)

454145f

fix(tui): preserve workspace while reconnecting (anomalyco#38788)

8281489

fix(core): close promise plugin event subscriptions on scope teardown

72b4e88

Fixes anomalyco#36677 Co-authored-by: Cursor <[email protected]>

github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jul 25, 2026

tiffanychum changed the base branch from v2 to dev July 25, 2026 09:34

tiffanychum requested review from Brendonovich and Hona as code owners July 25, 2026 09:34

github-actions Bot removed needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels Jul 25, 2026

tiffanychum closed this Jul 25, 2026

tiffanychum mentioned this pull request Jul 25, 2026

core: long-lived V2 server enters persistent allocation loop #36677

Closed

tiffanychum reopened this Jul 25, 2026

tiffanychum closed this Jul 25, 2026

Navigation Menu

Repository navigation

fix(core): close promise plugin event subscriptions on scope teardown - #38825

fix(core): close promise plugin event subscriptions on scope teardown#38825
tiffanychum wants to merge 849 commits into
anomalyco:devfrom
tiffanychum:fix/36677-plugin-event-leak

tiffanychum commented Jul 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

tiffanychum commented Jul 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

tiffanychum commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

tiffanychum commented Jul 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tiffanychum commented Jul 25, 2026 •

edited

Loading