Repository navigation
Conversation
quark-zju
changed the title
Fix intermittent duplicate assistant responses reproduced in the web UI and correlated with client/server clock skew. This can happen in both ways: - Client clock is ahead: Duplicated responses from the server. - Client clock is behind: Missing response from the server. Resolves anomalyco#24476. Resolves anomalyco#25270. Agent-Model: gpt-5.6-sol Agent-Harness: codex
|
Additional real-world confirmation: we encountered this on OpenCode 1.18.10. A single user turn produced 699 assistant messages before it was manually aborted; 649 of those messages had The behavior is consistent with the ID-ordering termination bug described here, and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24476
Closes #25270
Type of change
What does this PR do?
Fix clock skew. So if the client and server have different clocks, server won't incorrectly respond 0 or >=2 times.
How did you verify your code works?
Added tests.
Deployed this version to a server. Make the server time 5 minutes ahead and 5 minutes behind, check that in both cases the client's message gets one response, and the 2nd client message in a session also gets one response.
Screenshots / recordings
N/A
Checklist