Repository navigation
Conversation
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37884
Type of change
What does this PR do?
unknown certificate verification errorwas classified asUnknownError, so it bypassed the existing session retry policy and stopped the turn.This change classifies that specific transport failure as a retryable
APIError. It preserves the original error message and reuses the existing retry backoff. TLS verification remains enabled, and other certificate errors are unchanged.How did you verify your code works?
bun test test/session/retry.test.tsfrompackages/opencode: 34 tests passed.bun typecheckfrompackages/opencode.Screenshots / recordings
Not applicable; this is not a UI change.
Checklist