fix(server): enforce event stream ownership and diagnostics by armancharan · Pull Request #37585 · anomalyco/opencode

armancharan · 2026-07-18T01:52:36Z

Issue for this PR

Related: #36311 (minimal Bun SSE disconnect bridge on the event path only — not a platform-wide fix)

✧ raised · ○ in review · ● approved · ✓ merged

#36441 epic: scope streams + bound payloads

Merge in order:
v2
└ ○ #37486 location interest
   └ ○ #37487 session interest + fan-out bench
      └ ○ #37585 stream ownership / diagnostics ← this PR
         └ ○ #37586 reconnect herd

Siblings under the epic (not git parents of the stack tip):
└ ○ #37559 session blobs + payloadHash
└ ○ #37570 ensure-on-first-failure → feeds #37586

Stacked on #37487 (fix/event-subscription-sessions). GitHub base is v2 because the parent branch is fork-only; ownership-only diff: armancharan/opencode@fix/event-subscription-sessions...event-stream-ownership — retarget base onto that branch after #37487 merges (or when the branch exists on anomalyco).

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Guarantees one active event stream per TUI generation, prompt resource release on failure/teardown, and content-free diagnostics for leak detection.

TUI ownership: monotonic generation + await prior subscribe loop before opening the next; abort request AbortController on every exit; reconnect wait 1000 + random(0..500) ms so N clients do not phase-lock
Promise SSE: abort signal cancels the body reader (and response.body) so Bun sees client disconnect under custom fetch
Server: EventFeed.diagnostics() counters (active / opens / closes / serializedEvents / serializedBytes / overflows); debug GET /api/debug/event-feed; IncomingMessage aborted/close → ServerResponse.destroy() so acquireRelease runs (2.0: standalone SSE disconnect can wedge Bun server at 100% CPU #36311 bridge, event path only)

How did you verify your code works?

packages/server test/event-feed.test.ts — eleven-client churn → baseline; overflow counts; content-free dump
packages/server test/event-feed-fanout.bench.test.ts — from stack base: fan-out accounting laws (clients × sizes)
packages/server test/event-feed-ownership.test.ts — scope cancel → baseline; real-socket abort closes body; eleven sequential scopes never accumulate
packages/tui test/cli/tui/client-ownership.test.tsx — rapid interest ≤1 stream; teardown → 0; prior generation does not receive events after reconnect
packages/tui test/cli/tui/client-scope.test.tsx — connect / reconnect on change / no-op when unchanged (split)
typecheck in packages/server, packages/tui, and packages/cli

Acceptance → test

Claim	Test
One mounted TUI → one stream; zero after teardown	`teardown leaves zero active event streams` + `rapid interest changes never exceed one active event stream`
Reconnect churn never exceeds one stream per TUI	`rapid interest changes never exceed one active event stream`
Eleven clients → eleven streams (no accumulation)	`returns active subscriber count to baseline when scopes close after eleven-client churn` + `eleven sequential subscribe scopes never accumulate active subscribers`
Cancel real network client → response closed, baseline	`canceling a subscriber scope…` + `aborting a real Node HTTP client returns EventFeed.active to baseline`
Prior generation does not receive events after interest reconnect	`event IDs from a prior generation are not delivered after interest reconnect`
Diagnostics expose leaks without payloads	`returns active…` dump asserts + overflow counters

Screenshots / recordings

N/A — not a UI layout change.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

Co-authored-by: Cursor <[email protected]>

Narrow unknown event data with object/`in` checks so sessionID is read without an assertion. Co-authored-by: Cursor <[email protected]>

Helpers only need directory; no test supplies a workspace. Co-authored-by: Cursor <[email protected]>

No test supplies a workspace; avoid an unnecessary brand cast. Co-authored-by: Cursor <[email protected]>

Filter interested subscribers once before encode, require directory for location scope (reject workspace-only queries), and cover those cases in tests. Co-authored-by: Cursor <[email protected]>

Collect matching subscribers first so encode/offer share one pass. Co-authored-by: Cursor <[email protected]>

Extract pure interest helpers and cover subscribeInput/equality plus ClientProvider.event.scope reconnecting only when interest changes. Co-authored-by: Cursor <[email protected]>

Serialize TUI subscribe generations, cancel SSE readers on abort, bridge Bun disconnects so EventFeed queues release, and expose content-free feed counters for leak detection. Co-authored-by: Cursor <[email protected]>

Avoid a hard EventFeed.Service requirement on the debug handler so CLI serve Effect inference stays compatible with the runtime handler map. Co-authored-by: Cursor <[email protected]>

github-actions · 2026-07-18T01:52:45Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions · 2026-07-18T01:53:21Z

The following comment was made by an LLM, it may be inaccurate:

Based on my search, the PRs found are all explicitly mentioned as related work in PR #37585's description (parent stack and sibling work under #36441). These are not duplicates but intentionally related:

feat(server): opt-in location interest for event subscriptions #37486 - Parent: location interest (earlier in stack)
feat(server): narrow event subscriptions by session interest #37487 - Parent: session interest (immediate parent, this PR is stacked on it)
feat(core): bound tool and admitted event payloads via session blobs #37559 - Sibling: bound payloads (under same issue 2.0: Scope event streams and bound event payloads #36441)
test(cli): lock managed reconnect ensure-on-first-failure #37570 - Sibling: ensure-on-first-failure (under same issue 2.0: Scope event streams and bound event payloads #36441)

No duplicate PRs found

Replace the hand-rolled unknown guards with decodeUnknownOption so ephemeral sessionID extraction matches host Schema patterns. Co-authored-by: Cursor <[email protected]>

Map HttpApi-decoded ctx.query through interestFromSubscribeQuery, and route deepObject URLSearchParams through the same Schema before building Interest. Co-authored-by: Cursor <[email protected]>

Also derive EventFeed.Diagnostics from the protocol Schema and lock the generation boundary so prior-generation event IDs are not delivered. Co-authored-by: Cursor <[email protected]>

One test was asserting connect, interest change, and no-op scope together. Split into three named cases with a shared mount helper. Co-authored-by: Cursor <[email protected]>

Co-authored-by: Cursor <[email protected]>

armancharan · 2026-08-17T02:51:47Z

Closing this. The change set is too large to review against current v2, and I am not going to rebase it. Happy to revisit as a much smaller, issue-first PR if this is still wanted.

armancharan and others added 14 commits July 17, 2026 21:58

feat(server): opt-in location interest for event subscriptions

3eac0eb

Co-authored-by: Cursor <[email protected]>

feat(server): narrow event subscriptions by session interest

8c92fcc

Co-authored-by: Cursor <[email protected]>

style(tui): alphabetize ClientProvider props

7bfcc92

Co-authored-by: Cursor <[email protected]>

style(tui): alphabetize ClientProvider props

7674f99

Co-authored-by: Cursor <[email protected]>

refactor(schema): drop cast in sessionIDOf

162a75f

Narrow unknown event data with object/`in` checks so sessionID is read without an assertion. Co-authored-by: Cursor <[email protected]>

test(server): drop unused workspaceID from event fixtures

6f87215

Helpers only need directory; no test supplies a workspace. Co-authored-by: Cursor <[email protected]>

test(server): drop unused workspaceID from event fixture

4b54724

No test supplies a workspace; avoid an unnecessary brand cast. Co-authored-by: Cursor <[email protected]>

merge: bring location-interest fixture cleanup into session stack

3c58e70

refactor(server): tighten event subscription interest matching

f637389

Filter interested subscribers once before encode, require directory for location scope (reject workspace-only queries), and cover those cases in tests. Co-authored-by: Cursor <[email protected]>

refactor(server): filter event-feed interest once before encode

51ff5f8

Collect matching subscribers first so encode/offer share one pass. Co-authored-by: Cursor <[email protected]>

merge: bring location-interest encode-once filter into session stack

9e50e73

test(tui): lock event interest query shape and scope reconnect

7444cfa

Extract pure interest helpers and cover subscribeInput/equality plus ClientProvider.event.scope reconnecting only when interest changes. Co-authored-by: Cursor <[email protected]>

fix(server): enforce event stream ownership and diagnostics

0d49a51

Serialize TUI subscribe generations, cancel SSE readers on abort, bridge Bun disconnects so EventFeed queues release, and expose content-free feed counters for leak detection. Co-authored-by: Cursor <[email protected]>

fix(server): read event-feed diagnostics via serviceOption

af08507

Avoid a hard EventFeed.Service requirement on the debug handler so CLI serve Effect inference stays compatible with the runtime handler map. Co-authored-by: Cursor <[email protected]>

github-actions Bot added the needs:issue label Jul 18, 2026

armancharan mentioned this pull request Jul 18, 2026

fix(tui): desynchronize managed reconnect ensure herd #37586

Closed

3 of 6 tasks

armancharan commented Jul 18, 2026

View reviewed changes

Comment thread packages/schema/src/event.ts Resolved

refactor(schema): decode sessionIDOf data via Schema

d7325fd

Replace the hand-rolled unknown guards with decodeUnknownOption so ephemeral sessionID extraction matches host Schema patterns. Co-authored-by: Cursor <[email protected]>

armancharan marked this pull request as draft July 18, 2026 02:09

armancharan and others added 3 commits July 18, 2026 12:10

merge: bring sessionIDOf Schema decode into ownership stack

2173286

refactor(server): decode event interest via EventSubscribeQuery

7232360

Map HttpApi-decoded ctx.query through interestFromSubscribeQuery, and route deepObject URLSearchParams through the same Schema before building Interest. Co-authored-by: Cursor <[email protected]>

merge: bring EventSubscribeQuery interest decode into ownership stack

fabaeda

Also derive EventFeed.Diagnostics from the protocol Schema and lock the generation boundary so prior-generation event IDs are not delivered. Co-authored-by: Cursor <[email protected]>

armancharan commented Jul 18, 2026

View reviewed changes

Comment thread packages/tui/test/cli/tui/client-scope.test.tsx Resolved

armancharan and others added 2 commits July 18, 2026 12:37

test(tui): split event.scope reconnect assertions

364c7a5

One test was asserting connect, interest change, and no-op scope together. Split into three named cases with a shared mount helper. Co-authored-by: Cursor <[email protected]>

merge: bring split event.scope tests into ownership stack

9deb064

Co-authored-by: Cursor <[email protected]>

armancharan marked this pull request as ready for review July 18, 2026 02:44

test(tui): share mount and stream tracker in ownership suite

1a2e1a7

Co-authored-by: Cursor <[email protected]>

armancharan commented Jul 18, 2026

View reviewed changes

Comment thread packages/tui/src/context/event-interest.ts Resolved

armancharan commented Jul 18, 2026

View reviewed changes

Comment thread packages/tui/test/cli/tui/client-scope.test.tsx Resolved

armancharan and others added 2 commits July 18, 2026 13:14

refactor(tui): clarify subscribeInput locals and drop test bangs

1963373

Co-authored-by: Cursor <[email protected]>

merge: bring subscribeInput clarity into ownership stack

49e7e02

armancharan and others added 3 commits July 18, 2026 14:00

test(server): prove Node HTTP abort releases EventFeed subscribers

b79e543

Co-authored-by: Cursor <[email protected]>

test(server): add non-gating EventFeed fan-out benchmark

85f9a1f

Co-authored-by: Cursor <[email protected]>

merge: bring EventFeed fan-out benchmark into ownership stack

ffbf5be

kitlangton added the 2.0 label Jul 19, 2026

kitlangton self-assigned this Jul 19, 2026

Merge origin/v2 into event-stream-ownership

344007a

armancharan closed this Aug 17, 2026

neriousy mentioned this pull request Oct 21, 2026

2.0: Enforce event-stream ownership, cleanup, and diagnostics #36445

Closed

Navigation Menu

Repository navigation

fix(server): enforce event stream ownership and diagnostics - #37585

fix(server): enforce event stream ownership and diagnostics#37585
armancharan wants to merge 27 commits into
anomalyco:v2from
armancharan:event-stream-ownership

armancharan commented Jul 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

armancharan commented Aug 17, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

armancharan commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Acceptance → test

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

armancharan commented Aug 17, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

armancharan commented Jul 18, 2026 •

edited

Loading