Repository navigation
fix(tui): correct truncateLeft output when len is 1 - #37369
Closed
chinesepowered wants to merge 1 commit into
Closed
chinesepowered wants to merge 1 commit into
chinesepowered wants to merge 1 commit into
Conversation
This was referenced Jul 17, 2026
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37368
Type of change
What does this PR do?
truncateLeft(str, len)ended with"…" + str.slice(-(len - 1)). Whenlen === 1that isstr.slice(-0), andslice(-0)equalsslice(0)— the whole string — so the function returned something longer than the input (truncateLeft("abcdef", 1)→"…abcdef").This replaces the negative index with an equivalent positive one:
str.slice(str.length - (len - 1)). Atlen === 1that becomesstr.slice(str.length)→"", giving"…". For everylen >= 2the two expressions are identical, so existing behavior is unchanged. This also brings it in line with the siblingtruncate(), which already handleslen === 1correctly.How did you verify your code works?
Ran the old and new implementations side by side over a range of lengths:
len === 1: old"…abcdef"(7 chars) → new"…"(1 char) ✅len === 2, 3, 5: identical output to before ("…f","…ef","…cdef") ✅len >= str.length: returns the string unchanged ✅One-character diff, no caller changes needed.
Screenshots / recordings
N/A — not a UI change.
Checklist