Skip to content

fix(opencode): ignore node_modules during config and skill discovery - #37219

Closed
ulises-jeremias wants to merge 3 commits into
anomalyco:devfrom
ulises-jeremias:fix/opencode-ignore-node-modules-scan-v2
Closed

fix(opencode): ignore node_modules during config and skill discovery#37219
ulises-jeremias wants to merge 3 commits into
anomalyco:devfrom
ulises-jeremias:fix/opencode-ignore-node-modules-scan-v2

Conversation

@ulises-jeremias

@ulises-jeremias ulises-jeremias commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #30337

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Config and skill discovery use glob scans rooted at .opencode/ with recursive patterns (**/*.md, **/SKILL.md) and traverse every directory — including node_modules/ installed by @opencode-ai/plugin. This causes a startup hang/freeze when .opencode/node_modules/ exists with thousands of files.

Changes:

  1. packages/core/src/util/glob.ts — add ignore option to Glob.Options and thread it through to the underlying glob implementation
  2. packages/opencode/src/config/agent.ts — ignore **/node_modules/** in agent/mode discovery
  3. packages/opencode/src/config/command.ts — ignore **/node_modules/** in command discovery
  4. packages/opencode/src/config/plugin.ts — ignore **/node_modules/** in plugin discovery
  5. packages/opencode/src/skill/index.ts — ignore **/node_modules/** in skill scanning

How did you verify your code works?

Added regression tests for each affected path:

  • Glob.scan ignores **/node_modules/** patterns
  • Config discovery ignores agents/commands under .opencode/node_modules/
  • Skill discovery ignores skills under .opencode/node_modules/

Screenshots / recordings

N/A — no UI changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added contributor needs:compliance This means the issue will auto-close after 2 hours. labels Jul 16, 2026
@ulises-jeremias ulises-jeremias mentioned this pull request Jul 16, 2026
Closed
@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@ulises-jeremias
fix(opencode): ignore node_modules during config and skill discovery
13fc1fc 
Closes anomalyco#30337

Config and skill discovery use glob scans rooted at .opencode/
with recursive patterns (**/*.md, **/SKILL.md) and follow every
directory — including node_modules/ installed by @opencode-ai/plugin.

Add ignore: ["**/node_modules/**"] to all .opencode/ glob scans
and thread the ignore option through Glob.scan's Options interface.
@ulises-jeremias
ulises-jeremias force-pushed the fix/opencode-ignore-node-modules-scan-v2 branch from a17f781 to 13fc1fc Compare July 16, 2026 04:28
@kdb424

kdb424 commented Jul 21, 2026

Copy link
Copy Markdown

This solves an actual issue. Thank you for fixing this!

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.opencode/node_modules/ causes startup hang — scanner doesn't skip node_modules despite .gitignore

2 participants

@ulises-jeremias @kdb424