Repository navigation
Conversation
Signed-off-by: Ho Lim <[email protected]>
This was referenced Jul 9, 2026
Author
|
Closing after re-auditing the normalized usage semantics. DeepSeek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35974
Type of change
What does this PR do?
DeepSeek reports cache usage as top-level
usage.prompt_cache_hit_tokensandusage.prompt_cache_miss_tokens. The OpenAI-compatible chat parser did not keep those fields, so DeepSeek cache misses always ended up ascacheWriteInputTokens: undefined.This keeps those usage fields, maps hits to
cacheReadInputTokens, maps misses tocacheWriteInputTokens, and computes fresh input tokens after subtracting both buckets. The added fixture covers a 5-token prompt with 3 cache-hit tokens and 2 cache-miss tokens.How did you verify your code works?
The new test fails on
origin/dev: read/write cache fields are missing andnonCachedInputTokensstays at 5.After the fix:
cd packages/llm && bun test --timeout 30000 test/provider/openai-compatible-chat.test.ts test/provider/openai-chat.test.tsbun --cwd packages/llm testbun --cwd packages/llm typecheckbun lint packages/llm/src/protocols/openai-chat.ts packages/llm/test/provider/openai-compatible-chat.test.tsScreenshots / recordings
N/A, no UI change.
Checklist