Skip to content

fix(event): remove directory filter from SSE stream for worktree sessions - #35913

Closed
EZotoff wants to merge 1 commit into
anomalyco:devfrom
EZotoff:fix/sse-worktree-event-filter
Closed

EZotoff wants to merge 1 commit into
anomalyco:devfrom
EZotoff:fix/sse-worktree-event-filter

Conversation

@EZotoff

@EZotoff EZotoff commented Jul 8, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #35917

Type of change

  • Bug fix

What does this PR do?

The SSE event handler filters events by event.location?.directory === instance.directory. When a session runs inside a git worktree, the working directory differs from the configured instance directory. All events fail the filter and are silently dropped — the TUI receives no tool completions, message streaming, or permission prompts.

The fix removes the directory filter condition. The workspaceID filter is retained, which correctly scopes events to the current workspace regardless of directory path. Added ?.' null-safety to the workspaceIDaccess since the directory guard that previously impliedlocation` is defined is gone.

How did you verify your code works?

Built and deployed locally on v1.17.9. Verified that worktree sessions receive SSE events (tool completions, message parts, permission prompts) after the fix. Non-worktree sessions are unaffected — the workspaceID filter still scopes correctly.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@EZotoff
EZotoff force-pushed the fix/sse-worktree-event-filter branch from 573bbf4 to fdb986c Compare August 7, 2026 09:09
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: SSE event stream drops all events for worktree sessions

1 participant