Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
573bbf4 to
fdb986c
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #35917
Type of change
What does this PR do?
The SSE event handler filters events by
event.location?.directory === instance.directory. When a session runs inside a git worktree, the working directory differs from the configured instance directory. All events fail the filter and are silently dropped — the TUI receives no tool completions, message streaming, or permission prompts.The fix removes the
directoryfilter condition. TheworkspaceIDfilter is retained, which correctly scopes events to the current workspace regardless of directory path. Added?.' null-safety to theworkspaceIDaccess since the directory guard that previously impliedlocation` is defined is gone.How did you verify your code works?
Built and deployed locally on v1.17.9. Verified that worktree sessions receive SSE events (tool completions, message parts, permission prompts) after the fix. Non-worktree sessions are unaffected — the
workspaceIDfilter still scopes correctly.Checklist