Skip to content

fix(core): wait for plugin boot before session turns - #35660

Closed
fengjikui wants to merge 1 commit into
anomalyco:devfrom
fengjikui:plugin-ready-runner
Closed

fengjikui wants to merge 1 commit into
anomalyco:devfrom
fengjikui:plugin-ready-runner

Conversation

@fengjikui

@fengjikui fengjikui commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #35556

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

PluginInternal still starts its boot work asynchronously, but now exposes a ready effect that joins the initial boot fiber. SessionRunnerLLM waits for that readiness after confirming the session belongs to the current Location and before selecting the agent, preparing system context, resolving the model, or materializing tools. This prevents the first session turn from observing an empty/partial plugin generation, while unrelated Location consumers remain ungated. Plugin boot failures also surface before a provider stream starts.

How did you verify your code works?

  • cd packages/core && bun test test/session-runner.test.ts
  • cd packages/core && bun test test/session-runner-recorded.test.ts
  • cd packages/core && bun test test/plugin.test.ts
  • cd packages/core && bun typecheck
  • pre-push hook: bun turbo typecheck (30 tasks)

Screenshots / recordings

N/A, core session-runner change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V2: first Location can expose an empty plugin generation

1 participant