Repository navigation
feat(core): structure system context updates - #35045
Closed
kitlangton wants to merge 3 commits into
Closed
kitlangton wants to merge 3 commits into
kitlangton wants to merge 3 commits into
Conversation
Contributor
Author
|
Closing for now; WP-C is not being pursued in this lane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
packages/core/src/system-context: adds source descriptions, structured reconcile updates, structured update normalization, anddiffItemsreuse for keyed list diffs.packages/core/src/{instruction-context,system-context/builtins,session/context-entry}: supplies source descriptions.packages/core/src/{skill,reference,mcp}/guidance.ts: supplies source descriptions and item-level structured updates from existingdiffByKeyresults.packages/core/test: covers structured updates, item updates, removal metadata, and updated runner checkpoint snapshots.Decisions / Deferrals
context-checkpoint.tspublish payload is intentionally unchanged in WP-C; WP-F owns thesession.guidance.updatedschema/UI event swap.Part of #35017
Part of #35021
Test Plan
cd packages/core && bun typecheckcd packages/core && bun run test -- test/system-context/index.test.ts test/instruction-context.test.ts test/session-runner.test.tsbunx prettier --check packages/core/src/system-context/index.ts packages/core/src/skill/guidance.ts packages/core/src/reference/guidance.ts packages/core/src/mcp/guidance.ts packages/core/src/instruction-context.ts packages/core/src/session/context-entry.ts packages/core/src/system-context/builtins.ts packages/core/test/system-context/index.test.ts packages/core/test/instruction-context.test.ts packages/core/test/session-runner.test.tsbun turbo typecheck