Repository navigation
Conversation
The env-var path of Auth.all() returned JSON.parse() directly without applying Record.filterMap(decode), letting invalid entries (wrong type, non-object, missing fields) reach downstream provider code that switches on info.type. The empty catch block silently swallowed JSON parse errors, so malformed OPENCODE_AUTH_CONTENT fell through to file-based auth despite the user explicitly setting the env var. Apply the same Record.filterMap(decode) validation the file path already uses, surface parse and type errors as AuthError, and reject non-object top-level JSON (arrays, primitives, null). Six new regression tests in test/auth/auth.test.ts cover both bugs plus the no-regression cases (empty/unset env var still falls through to file path). Closes anomalyco#34075
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #34075
Type of change
What does this PR do?
In
packages/opencode/src/auth/index.tsAuth.all(), the env-var path ofOPENCODE_AUTH_CONTENTreturnedJSON.parse(...)directly, bypassing theRecord.filterMap(decode)schema validation that the file-based path applies. The emptycatchblock silently swallowed JSON parse errors, so a malformed env var fell through to file-based auth even though the user had explicitly set it.Two consequences:
type, missingtype, non-object values) reached downstream provider code that switches oninfo.type(e.g.provider/auth.ts:167).The fix:
try/catchwithEffect.try({ try, catch })to surface parse errors asAuthError.AuthError.Record.filterMap(decode)validation that the file path already uses, so invalid entries are silently filtered (matching existing file-path behavior) but parse/type errors surface loudly.The file-path branch is untouched.
How did you verify your code works?
The 6 new regression tests in
test/auth/auth.test.tsreproduce both bugs against the unmodified code (3 of 6 fail before the fix), and verify that empty/unset env vars still fall through to the file path. The cross-cluster run covers every other consumer ofAuth(provider, control-plane, server, MCP, CLI/ACP) and confirms no regressions.Screenshots / recordings
N/A — not a UI change.
Checklist