Repository navigation
fix(provider): forward agent temperature for config-defined custom models - #34555
Closed
SeashoreShi wants to merge 1 commit into
Closed
SeashoreShi wants to merge 1 commit into
SeashoreShi wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #34554
Type of change
What does this PR do?
Config-defined custom models currently default
capabilities.temperaturetofalsewhen the model entry omits that field. That causesagent.temperatureto be stripped before the OpenAI-compatible request is built.This PR defaults custom-model temperature support to enabled unless the config explicitly sets
temperature: false, and adds regression coverage for both provider merging and the request payload.How did you verify your code works?
bun test test/provider/provider.test.ts test/session/llm.test.tsbun run typecheckScreenshots / recordings
N/A
Checklist