Repository navigation
fix(tui): truncateMiddle returns the whole string when maxLength is 1 or 2 - #34482
Closed
Osamaali313 wants to merge 1 commit into
Closed
Osamaali313 wants to merge 1 commit into
Osamaali313 wants to merge 1 commit into
Conversation
keepEnd is 0 at those widths, and str.slice(-0) returns the entire string, so truncateMiddle produced output longer than the input (e.g. the run splash detail line overflows on narrow terminals). Skip the end slice when keepEnd is 0.
github-actions
Bot
added
the
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
3 of 6 tasks
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
3 of 6 tasks
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20880
Type of change
What does this PR do?
truncateMiddle(packages/tui/src/util/locale.ts) returns the whole string whenmaxLengthis 1 or 2. At those widthskeepEndis 0, andstr.slice(-0)slices from index 0 (returns everything) instead of nothing — so the result is longer than the input, and the run splash detail line overflows on very narrow terminals. The fix skips the end slice whenkeepEndis 0.How did you verify your code works?
Added
packages/tui/test/util/locale.test.ts:truncateMiddle("hello-world", 1)now returns"…"and(..., 2)returns"h…"; widths >= 3 are unchanged.Checklist