Repository navigation
opentui: add toast & port flags (-c, -s) - #3425
Conversation
|
generally if possible I'd recommend splitting into 2 prs if we can help it |
| }, | ||
| }) | ||
| onSelect: async (dialog) => { | ||
| try { |
There was a problem hiding this comment.
can we use .catch instead of try catch
| } | ||
| return undefined | ||
| })() | ||
| const sessionID = "make-typechecker-happy" |
There was a problem hiding this comment.
I think you should just leave this file as it was we aren't using it anywhere right? so no reason to make edits unless u wanted to delete it?
There was a problem hiding this comment.
I wanted to mark stuff that was done. Since there is no such tracking by the other devs rn, I'll remove it before marking this PR as ready. But I'll keep it for now for my own organization.
|
Yeah I think this is good, if you drop that one file edit I think this is good to merge |
|
@rekram1-node Please check the newest commits. Now it's ready to merge. Made these changes:
|
This reverts commit 98d6530.
rekram1-node
changed the title
|
I think this is awesome, great work |
Uh oh!
There was an error while loading. Please reload this page.