fix(tui): prevent piped stdin from breaking UI and keyboard input by LordMikkel · Pull Request #34242 · anomalyco/opencode

LordMikkel · 2026-06-27T16:11:07Z

Issue for this PR

Closes #28538
Closes #24195
Closes #3871
Closes #6220

Replaces #28540, which was closed by the automated PR cleanup bot before maintainer review.

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

When stdin is piped, the TUI renderer can read keyboard input from the pipe instead of the terminal. That breaks the UI and keyboard control for a simple command like:

echo "hello" | opencode

The run command already handles this with resolveInteractiveStdin(). This PR applies the same approach to the TUI: pass the controlling terminal (/dev/tty on Linux, CONIN$ on Windows) to the renderer while still consuming piped stdin as the prompt.

How did you verify your code works?

bun --cwd packages/opencode test runtime.stdin
bun --cwd packages/opencode typecheck
Manual case to validate in a real terminal: echo "hello" | opencode

Screenshots / recordings

With the fix:

Without the fix:

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

github-actions · 2026-06-27T16:14:06Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

andrei-hasna · 2026-06-27T22:39:40Z

Local merge/validation note from review queue:

Validated locally against current dev (ae53163):

PR head 571459c merges cleanly with no conflicts.
packages/opencode typecheck passes.
packages/tui typecheck passes.
packages/opencode test/cli/run/runtime.stdin.test.ts passes.
packages/tui test/app-lifecycle.test.tsx passes.
Changed-file oxlint exits 0, with existing warnings outside the added lines.

I would not merge this yet. Remaining blockers found in review:

The resolved interactive stdin is passed to the TUI renderer, but TUI openEditor() call sites still omit it. External editor launches therefore inherit the original pipe/EOF after flows like echo prompt | opencode, so editor-based prompt/session export workflows can still have broken stdin.
The Windows CONIN$ path needs another pass: Ctrl+C guard, processed-input disable, and input-buffer flush still operate on process.stdin, not the resolved renderer stdin.
The no-controlling-terminal error currently reuses --mini requires a controlling terminal for input, which is misleading for the non-mini TUI path.

Also, the branch is currently stale relative to dev (1 ahead / 9 behind); GitHub reports mergeStateStatus=BLOCKED even though the content is MERGEABLE locally.

andrei-hasna · 2026-06-28T02:12:30Z

Revalidated by the merge queue on 2026-06-28 against current dev (61a7f6d) and PR head 571459c.

What passed:

PR still applies cleanly locally; git merge-tree origin/dev refs/remotes/pr/34242 succeeds.
git diff --check origin/dev...refs/remotes/pr/34242 passes.
bun --cwd packages/opencode test --timeout 30000 test/cli/run/runtime.stdin.test.ts test/cli/tui/thread.test.ts passes.
bun run --cwd packages/opencode typecheck passes.
bun run --cwd packages/tui typecheck passes.
Changed-file oxlint has 0 errors; warnings are on pre-existing lines.

Still not merging yet. The blockers from the previous review comment still apply because the head commit has not changed:

TUI external editor call sites still omit the resolved stdin, so editor workflows can inherit the original pipe/EOF.
Windows processed-input/flush/Ctrl+C guard paths still key off process.stdin, not the resolved interactive stdin stream.
The no-controlling-terminal error text is still mini-specific for the standard TUI path.
GitHub reports mergeStateStatus=BLOCKED; the branch is now 1 ahead / 11 behind current dev.

Please address those before this is merge-ready.

andrei-hasna · 2026-06-28T04:48:19Z

Revalidated by the merge queue on 2026-06-28 against current dev (dfeb1b505) and PR head 571459c.

What passed locally in an isolated worktree:

PR merges cleanly into current dev with no conflicts.
git diff --check passes.
bun --cwd packages/opencode test --timeout 30000 test/cli/run/runtime.stdin.test.ts test/cli/tui/thread.test.ts passes.
bun --cwd packages/tui test --timeout 30000 test/app-lifecycle.test.tsx passes.
bun run --cwd packages/opencode typecheck passes.
bun run --cwd packages/tui typecheck passes.
Changed-file oxlint has 0 errors; warnings are on pre-existing lines.

Still not merging. Independent review confirmed the remaining blockers:

The resolved interactive stdin is only passed to the OpenTUI renderer. TUI openEditor() call sites still omit it, so editor launches can inherit the original piped stdin/EOF after flows like echo prompt | opencode.
Windows terminal handling still keys off process.stdin: Ctrl+C guard, processed-input disable, and input-buffer flush do not use the resolved CONIN$ stream passed to the renderer.
The no-controlling-terminal error text still says --mini requires a controlling terminal for input, which is misleading for the standard TUI path now using the same resolver.
GitHub still reports mergeStateStatus=BLOCKED; branch divergence is 12 1 (dev ahead / PR ahead).

Please address those before this is merge-ready.

andrei-hasna · 2026-06-28T11:36:40Z

Revalidated by the merge queue on 2026-06-28 against current dev (6ee817d) and PR head 571459c.

What passed locally in an isolated worktree:

PR merges cleanly into current dev with no conflicts.
git diff --check passes.
bun --cwd packages/opencode test --timeout 30000 test/cli/run/runtime.stdin.test.ts test/cli/tui/thread.test.ts passes (13/13).
bun --cwd packages/tui test --timeout 30000 test/app-lifecycle.test.tsx passes (2/2; same pre-existing KV ENOENT logs).
bun run --cwd packages/opencode typecheck passes.
bun run --cwd packages/tui typecheck passes.
Changed-file oxlint reports 0 errors; warnings are on pre-existing lines.

Still not merging. Independent adversarial review confirmed the remaining blockers:

TUI external editor call sites still omit the resolved interactive stdin, so editor workflows can inherit the original piped stdin/EOF after flows like echo prompt | opencode.
Windows terminal handling still keys off process.stdin: Ctrl+C guard, processed-input disable, and input-buffer flush do not use the resolved CONIN$ stream.
The no-controlling-terminal error text still says --mini requires a controlling terminal for input, which is misleading for the standard TUI path.
GitHub still reports mergeStateStatus=BLOCKED; branch divergence is 13 behind / 1 ahead current dev.

Please address those before this is merge-ready.

LordMikkel · 2026-06-28T11:52:41Z

@andrei-hasna Thanks for the thorough review!

I addressed the blockers:

Passed the resolved stdin to TUI editor calls.
Updated Windows terminal handling to use the resolved stdin.
Fixed the TUI controlling-terminal error message.
Updated the branch against current dev.

Your detailed feedback was really valuable!

# Conflicts: # packages/tui/src/app.tsx

precelca · 2026-07-02T17:14:24Z

Tested the latest revision, and I can confirm this fixes the issue for me. I can now pipe stdin into the TUI without losing keyboard input.

andrei-hasna · 2026-07-05T12:55:12Z

Worker review update for the current head 86812a12 against current origin/dev b7e4f1e:

Not merging as-is. Local synthetic merge into current dev applies cleanly, and focused validation passed:

bun typecheck from packages/opencode
bun test test/cli/run/runtime.stdin.test.ts --timeout 30000 from packages/opencode
bun typecheck from packages/tui
bun test test/editor.test.ts --timeout 30000 from packages/tui
git diff --cached --check

Merge blockers:

GitHub still reports mergeStateStatus=BLOCKED, reviewDecision empty, and no latest reviews.
Branch is stale versus current dev: origin/dev...origin/pr/34242 is 80 commits behind / 4 ahead in this local fetch.
Adversarial review found a Windows cleanup-order risk in the merged diff: packages/opencode/src/cli/cmd/tui.ts calls interactiveStdin?.cleanup?.() before unguard?.(), while packages/tui/src/terminal-win32.ts restores console mode using the handle captured from that stdin stream. On Windows piped-stdin TUI, restore can depend on a closed CONIN$ handle. Call the guard cleanup before destroying the alternate stdin stream.
Regression coverage is still thin for the full TUI piped-stdin path, editor stdin handoff, keyboard input preservation, and Windows guard cleanup ordering.

Recommendation: update/rebase the PR, fix the cleanup ordering, add focused regression coverage, and rerun CI on the updated GitHub merge ref before re-entering the merge queue.

LordMikkel · 2026-07-06T00:37:03Z

@andrei-hasna Thanks again for the careful review and feedback.

Fixed the cleanup ordering: the guard cleanup now runs before closing the alternate stdin stream. Also removed a accidental scratch comment.

Drop the stdin context in favor of renderer.stdin, and trim the win32 console helpers back to the original shape.

# Conflicts: # packages/tui/src/app.tsx

_get_osfhandle aborts the process when given a Bun-opened fd, so echo hi | opencode would crash on Windows. Open a dedicated CONIN$ handle instead; every CONIN$ handle shares the same console input buffer.

Resolve the terminal stream before the TUI try block so both handles stay const, name the win32 CreateFileW flags, and add a Windows-only test that exercises the console helpers with a separately opened CONIN$ stream.

LordMikkel · 2026-09-25T01:12:43Z

Updated against the latest dev and resolved the conflict.

I also tested it on Windows this time and found that the previous version crashed with piped stdin: _get_osfhandle doesn't recognize Bun's fds and aborts the process. It now opens its own CONIN$ handle instead and works correctly.

thdxr · 2026-10-10T17:39:20Z

This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2.

— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊

fix(tui): prevent piped stdin from breaking UI and keyboard input

571459c

github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jun 27, 2026

LordMikkel added 2 commits June 28, 2026 13:47

fix(tui): complete piped stdin handling

ba45d6e

Merge remote-tracking branch 'upstream/dev' into fix/tui-stdin-pipe-v2

dee28f5

Merge remote-tracking branch 'upstream/dev' into fix/tui-stdin-pipe-v2

86812a1

# Conflicts: # packages/tui/src/app.tsx

LordMikkel added 2 commits July 6, 2026 02:18

Merge branch 'dev' into fix/tui-stdin-pipe-v2

d953085

fix(tui): restore stdin guard before cleanup

bf8dee5

github-actions Bot mentioned this pull request Jul 6, 2026

📊 AI CLI 工具社区动态日报 2026-07-06 litang9/big_model_radar#169

Open

mathew-cf mentioned this pull request Aug 10, 2026

fix(tui): isolate tool stdin #41613

Closed

3 of 6 tasks

github-actions Bot mentioned this pull request Aug 13, 2026

fix(tui): exit on empty non-interactive stdin #42235

Closed

3 of 6 tasks

LordMikkel added 6 commits September 25, 2026 02:04

refactor(tui): use renderer stdin for external editor

4d754a9

Drop the stdin context in favor of renderer.stdin, and trim the win32 console helpers back to the original shape.

Merge remote-tracking branch 'upstream/dev' into fix/tui-stdin-pipe-v2

0af48ba

# Conflicts: # packages/tui/src/app.tsx

fix(tui): open CONIN$ directly for piped stdin on windows

488e574

_get_osfhandle aborts the process when given a Bun-opened fd, so echo hi | opencode would crash on Windows. Open a dedicated CONIN$ handle instead; every CONIN$ handle shares the same console input buffer.

chore(tui): drop leftover scratch comment

7df2ed4

test(tui): drop windows console test

b8e419a

thdxr closed this Oct 10, 2026

LordMikkel mentioned this pull request Oct 11, 2026

fix(tui): stop piped stdin from breaking UI and keyboard input #54539

Open

3 of 6 tasks

Navigation Menu

Repository navigation

fix(tui): prevent piped stdin from breaking UI and keyboard input - #34242

fix(tui): prevent piped stdin from breaking UI and keyboard input#34242
LordMikkel wants to merge 12 commits into
anomalyco:devfrom
LordMikkel:fix/tui-stdin-pipe-v2

LordMikkel commented Jun 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 27, 2026

Uh oh!

andrei-hasna commented Jun 27, 2026

Uh oh!

andrei-hasna commented Jun 28, 2026

Uh oh!

andrei-hasna commented Jun 28, 2026

Uh oh!

andrei-hasna commented Jun 28, 2026

Uh oh!

LordMikkel commented Jun 28, 2026 •

edited

Loading

Uh oh!

precelca commented Jul 2, 2026

Uh oh!

andrei-hasna commented Jul 5, 2026

Uh oh!

LordMikkel commented Jul 6, 2026 •

edited

Loading

Uh oh!

LordMikkel commented Sep 25, 2026

Uh oh!

thdxr commented Oct 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LordMikkel commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented Jun 27, 2026

Uh oh!

andrei-hasna commented Jun 27, 2026

Uh oh!

andrei-hasna commented Jun 28, 2026

Uh oh!

andrei-hasna commented Jun 28, 2026

Uh oh!

andrei-hasna commented Jun 28, 2026

Uh oh!

LordMikkel commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

precelca commented Jul 2, 2026

Uh oh!

andrei-hasna commented Jul 5, 2026

Uh oh!

LordMikkel commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LordMikkel commented Sep 25, 2026

Uh oh!

thdxr commented Oct 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LordMikkel commented Jun 27, 2026 •

edited

Loading

LordMikkel commented Jun 28, 2026 •

edited

Loading

LordMikkel commented Jul 6, 2026 •

edited

Loading