Repository navigation
Conversation
…mediately
When the user switches models in the UI, the local persisted store was updated but
the server's SessionTable.model was not — causing image/vision capabilities
to be stale until the next message was sent. This change adds a
POST /api/session/{sessionID}/model endpoint that publishes a ModelSwitched
event, keeping server-side session state consistent with UI model selection
in real time.
Closes anomalyco#33199
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
lexlian
changed the title
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33199
Type of change
What does this PR do?
Root cause: When the user switched models in the UI,
local.model.set()only updated the local persisted store. The server'sSessionTable.modelwas only updated when a prompt arrived with a differentmodel:field in the payload. The session runner resolved models usingSessionTable.model, causing image/vision capability checks to use the stale model between the UI switch and the next message.Fix: Added
POST /api/session/{sessionID}/modelendpoint that publishes aModelSwitchedevent. When the user changes models in the UI, the app now immediately callsclient.session.switchModel()to sync the change to the server. The projector (already wired incore/src/session.ts) handles persisting the new model toSessionTable.model.Files changed:
packages/app/src/context/local.tsx— callsswitchModel()aftermodel.set()packages/opencode/src/server/routes/instance/httpapi/groups/session.ts— new endpoint +SwitchModelPayloadschemapackages/opencode/src/server/routes/instance/httpapi/handlers/session.ts— handler callingsession.switchModel()packages/opencode/src/session/session.ts— addedswitchModeltoInterfaceand implemented viaevents.publish(SessionEvent.ModelSwitched, ...)How did you verify your code works?
bun test test/server/httpapi-session.test.ts— 19/19 pass including new test "switchModel endpoint updates session model and returns 204"bun test test/session-projector.test.ts— 7/7 passcd packages/opencode && bun typecheck— cleanChecklist