Repository navigation
fix(a11y): remove aria-hidden from streaming assistant content - #33139
Closed
ashu-choudhury wants to merge 2 commits into
Closed
ashu-choudhury wants to merge 2 commits into
ashu-choudhury wants to merge 2 commits into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This was referenced Jul 22, 2026
Closed
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33137
Type of change
What does this PR do?
While testing with NVDA, I noticed that assistant content is hidden from the accessibility tree while a response is being generated.
The assistant content container is rendered with:
This prevents screen reader users from accessing streamed assistant content, tool activity, and progress information that is visible on screen.
This change removes the
aria-hiddenattribute from the assistant content container so streamed content remains accessible during generation.How did you verify your code works?
Tested locally with NVDA on Windows.
Before this change, NVDA could access the thinking status but not the streamed assistant content while generation was in progress.
After this change, NVDA can access the streamed assistant content during generation.
Screenshots / recordings
Not provided.
Checklist