Repository navigation
Conversation
Refs: ISS-8648 Prepared with AI assistance.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Closing this because the latest validation narrowed the fix away from session/timeline model recovery. The current direction is to keep provider rate-limit / retry-advisory failures on the original-model retry path and avoid model-replacement fallback for those errors, rather than repairing fallback-created session model state after the fact. Keeping this PR open would point reviewers at a workaround that is no longer the intended fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33044
Type of change
What does this PR do?
Prevents internal/synthetic continuation model state from becoming the durable session model used by later normal user turns.
This patch:
Retry Error: ... You can retry your request ...as retryable even when SDK metadata is incompleteThis intentionally does not include the OpenAI Responses tool-count cap; that is already covered by #32998.
Prepared with AI assistance.
How did you verify your code works?
bun test --cwd packages/app --preload ./happydom.ts ./src/pages/session/timeline/model.test.ts ./src/pages/session/session-model-helpers.test.tsbun test --cwd packages/opencode test/session/retry.test.tsbun run --cwd packages/app typecheckbun run --cwd packages/opencode typecheckbun turbo typecheck(23/23 successful)Notes
packages/opencode/test/session/processor-effect.test.tscurrently needs broader upstream harness work in this checkout for provider catalog setup, so this PR keeps the processor behavior minimal and verifies the retry classifier/session-model surfaces directly.Screenshots / recordings
N/A — session/model state and retry behavior changes only.
Checklist