Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
|
ualtinok
force-pushed
the
stable-skill-dedupe
branch
from
June 14, 2026 05:04
3f27d94 to
4e5f471
Compare
This was referenced Jul 6, 2026
ualtinok
force-pushed
the
stable-skill-dedupe
branch
from
July 7, 2026 08:56
0b533db to
bbb6515
Compare
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Aug 3, 2026
Sort scan matches and discovered directories, and load skills sequentially instead of with unbounded concurrency, so that duplicate skill names resolve deterministically by source precedence (.opencode overrides .claude) rather than by nondeterministic load order. Ported from anomalyco#32203 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32202
Type of change
What does this PR do?
Makes duplicate skill discovery deterministic.
The skill catalog already renders sorted by skill name, but duplicate skill names were resolved while loading files with unbounded concurrency. Since duplicate names overwrite the previous entry, whichever file finished loading last won. That made the selected skill
locationunstable across restarts when the same skill name existed in multiple roots.This PR sorts matches within each scan and loads discovered skill files in discovery order, preserving the existing source precedence while removing the I/O race.
How did you verify your code works?
bun test test/skill/skill.test.tsbun typecheckScreenshots / recordings
N/A
Checklist