Repository navigation
fix: handle session not found errors without crashing the renderer - #32085
SisyphusZheng wants to merge 2 commits into
Conversation
When a session is deleted server-side while a user is viewing it, the throwOnError client config causes 404 errors to be thrown by the SDK. The catch handlers in directory-sync.ts were re-throwing these for tracked sessions (the ones the user is actively viewing), which propagated as unhandled promise rejections through the sync pipeline and crashed the renderer. Now 404 errors are always swallowed regardless of tracking state.
github-actions
Bot
added
the
needs:compliance
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:issue
and removed
needs:issue
needs:compliance
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #25131
Type of change
What does this PR do?
When Desktop restores or syncs a session ID that no longer exists on the active server, the SDK throws a 404 because the client is configured with
throwOnError: true.directory-sync.tsalready handled 404s for untracked sessions, but it re-threw the same 404 for tracked sessions. That made a missing active/restored session bubble through the sync pipeline as an unhandled rejection and crash the renderer.This PR changes the two session sync catch handlers to swallow
NotFoundError/404 responses for tracked sessions too. A deleted or stale session should no longer crash the renderer while the surrounding sync state catches up.How did you verify your code works?
Checked the affected sync path locally and confirmed the PR diff only changes the two
isNotFound(error)handlers inpackages/app/src/context/directory-sync.ts.Screenshots / recordings
Not applicable. This is an error handling change.
Checklist