Skip to content

fix: plan-build switch reminder spam, provider config limit optional - #31897

Closed
ghost wants to merge 2 commits into
devfrom
unknown repository
Closed

ghost wants to merge 2 commits into
devfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jun 11, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #31763 #31780

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fix plan-to-build switch reminder firing every turn and provider config schema requiring limit.output when limit is present.

How did you verify your code works?

Tested in custom fork, verified reminder fires only once and config loads without limit.output.

Screenshots / recordings

N/A - logic change, not UI

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

LifetimeVip added 2 commits June 11, 2026 06:19
… cap

- provider.ts: limit context/output now optional (your 1M context config no longer fails)
- transform.ts: remove 32K OUTPUT_TOKEN_MAX hard cap
- migrate.ts: handle undefined limit fields
@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@ghost

ghost commented Jun 11, 2026

Copy link
Copy Markdown
Author

@thdxr @jlongster @rekram1-node @simonklee @Hona these 8 PRs together fix 30 open issues (compaction context loss, Windows encoding, tool error handling, security, etc.). All are mergeable with no conflicts. Would appreciate a review when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] plan to build switch reminder fires every turn

1 participant