Repository navigation
Conversation
…ocks When a npm package specifier (e.g. oh-my-openagent@latest) deadlocks during import(), the process hangs indefinitely with no visible error. Wrapping import() with Promise.race + setTimeout surfaces a clear error message and allows other plugins to continue loading. Related: anomalyco#23143 anomalyco#25668
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31463
Type of change
What does this PR do?
PluginLoader.load()callsawait import(row.entry)with no timeout. The broader deadlock is inNpm.add()→ Arboristreify()(cold cache only), but adding a timeout toimport()prevents silent hangs regardless of where the deadlock occurs. If the import times out, a clear error is surfaced instead of an invisible hang.Root cause (confirmed via cache inspection)
The real deadlock is in
Npm.add()— Arboristreify()hangs when the npm cache is cold. Once~/.cache/opencode/packages/oh-my-openagent@latest/is populated, the cache fast-path skipsreify()and everything works. This is likely related to #23143 (no TTL on @latest re-reify).How did you verify your code works
oh-my-openagent@latestwith a cold cache triggeredNpm.add()→reify()successfully (populated the cache)Checklist