fix(opencode): strip MiniMax trailing tool_call leak suffix - #30849

Self-review summary:

• ✅ Scope is intentionally narrow: only trailing leak cleanup for MiniMax-model assistant text.
• ✅ Sanitization is gated by model id (minimax) to avoid changing other providers.
• ✅ Sanitizer removes only trailing artifacts (known marker and trailing </tool_call>), preserving normal content.
• ✅ Applied at text-end after plugin text-complete hook, so final persisted text is clean.
• ✅ Regression test added in processor effect tests to verify leaked suffix is removed.
• ✅ No unrelated behavior changes included.

Wondering, should we strip it? Or should we try to parse it as normal tool call?

Also for this:

Cannot find module '@opencode-ai/llm' from packages/core/src/session/event.ts

just run bun i

Good call, thanks!

You’re right on both points:

1. Parsing as a normal tool call is not ideal here because this artifact arrives as trailing plain assistant text (not a structured tool-call event), so at this layer we can only treat it as text cleanup.
2. I should have run bun i before claiming module-resolution blockers.

I installed deps (bun i) and re-ran the targeted test from packages/opencode:

• bun test test/session/processor-effect.test.ts -t "session.processor strips MiniMax trailing tool_call leak suffix from assistant text"

It now passes.

I also pushed a small follow-up test fix commit to align the processor return expectation in this test (continue in this harness setup).

@rekram1-node

Rebased onto latest dev and resolved the processor.ts merge conflict — kept the trailing leak sanitization on text-end and aligned with the upstream removal of the v2 mirrorAssistant path.

CI should re-run shortly. Happy to adjust the strip-vs-parse approach if you still prefer parsing as a structured tool call.

Rebased cleanly onto the latest dev with a linear history (3 commits, no merge commits).

During rebase, the sanitizer was adapted to the current processor.ts state:

• Removed the log = Log.create(...) line (unused in upstream/dev)
• Kept only the sanitizer call (sanitizeTrailingToolCallLeak) on text-end — the surrounding v2 mirrorAssistant / summary block was already removed from upstream/dev so those were dropped

CI is green. Ready for re-review @rekram1-node.

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.