Repository navigation
Conversation
|
Keymap layers can have a Edit: I meant sort is by priority first, then newer registration first. So priority takes precedence. |
9d0f9b6 to
295f73d
Compare
|
Updated, thanks. I switched this to a shared |
|
@kommander just checking if there's anything else needed here now that this uses the priority-based approach. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #29999
Type of change
What does this PR do?
Open dialogs could lose keyboard input when the TUI entered question/autocomplete mode. Keys intended for the dialog could be handled by the prompt state instead.
This PR gives dialog selection bindings higher priority so the active dialog gets first chance to handle its own keyboard input.
Global app/session bindings were also active while dialogs were open. This PR disables those global layers while
dialog.stackis non-empty, so leader shortcuts and session-level shortcuts do not run from inside an active modal.How did you verify your code works?
COMMAND_PALETTE_COMMAND.bun test test/cli/tui/keymap.test.tsx— 3/3 pass.bun typecheck— clean.Screenshots / recordings
Not included. This is a keyboard-state fix covered by keymap tests.
Checklist