Repository navigation
fix(opencode): serialize mcp-auth.json writes to prevent concurrent corruption - #29820
Closed
JunJieLiu51520 wants to merge 2 commits into
Closed
JunJieLiu51520 wants to merge 2 commits into
JunJieLiu51520 wants to merge 2 commits into
Conversation
…orruption McpAuth.set() and remove() used an unguarded read-modify-write pattern. Concurrent token refreshes or client info saves could race, causing one write to overwrite another and potentially corrupt mcp-auth.json. Add a Semaphore(1) so all file mutations are serialised, ensuring each read-modify-write cycle sees the latest file state. Closes anomalyco#29804
Verify that concurrent updateTokens, updateClientInfo, and remove calls do not corrupt mcp-auth.json and that all writes survive without data loss.
3 of 6 tasks
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29804
Type of change
What does this PR do?
McpAuth.set()andremove()used an unguarded read-modify-write pattern. Concurrent token refreshes or client info saves could race, causing one write to overwrite another — manifesting as extra}characters appended tomcp-auth.json, breaking JSON parsing and disconnecting all remote MCP servers.Added an
Effect.Semaphore(1)so all file mutations are serialised, ensuring each read-modify-write cycle sees the latest file state.How did you verify your code works?
Added 4 tests to
test/mcp/auth.test.ts:removeraces withupdateTokens; deletion and update both take effect correctlyChecklist