Skip to content

fix(task): surface non-text subagent results - #29176

Closed
YoungJurry wants to merge 1 commit into
anomalyco:devfrom
YoungJurry:fix-task-empty-subagent-result
Closed

fix(task): surface non-text subagent results#29176
YoungJurry wants to merge 1 commit into
anomalyco:devfrom
YoungJurry:fix-task-empty-subagent-result

Conversation

@YoungJurry

@YoungJurry YoungJurry commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #24447

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This fixes the task tool returning an empty <task_result> when a subagent completes without a final text part.

Before this change, TaskTool only looked for the last text part and fell back to "" if none existed. That made reasoning-only or non-text child completions look like blank results in the parent session.

This change keeps the existing behavior when a child returns text, and otherwise returns a short diagnostic summary with the finish reason, error, and emitted part types.

How did you verify your code works?

  • Ran bun run typecheck in packages/opencode
  • Ran bun test test/tool/task.test.ts --test-name-pattern "execute returns child text output when present|execute returns diagnostic output when child finishes without a text part"
  • Ran bun test test/cli/run/entry.body.test.ts test/cli/run/scrollback.surface.test.ts

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels May 25, 2026
@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@niStee

niStee commented May 27, 2026

Copy link
Copy Markdown

This is an interesting approach! Just out of curiosity, how does returning a diagnostic string here interact with the FallbackProvider? If the tool returns a string instead of throwing an error when a model fails to return text, won't that prevent the fallback chain from intercepting the failure and switching to the backup model?

@niStee niStee mentioned this pull request May 27, 2026
Closed
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TaskTool returns no diagnostic context when subagent result text is empty or missing

2 participants

@YoungJurry @niStee